[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-gc-dev
Subject:    Re: Request for review - 8013184 CMS: Call reset_after_compaction() only if a compaction has been do
From:       Thomas Schatzl <thomas.schatzl () oracle ! com>
Date:       2013-04-30 12:46:56
Message-ID: 1367326016.2722.82.camel () cirrus
[Download RAW message or body]

Hi,

On Thu, 2013-04-25 at 12:32 -0700, Jon Masamitsu wrote:
> 8013184: CMS: Call reset_after_compaction() only if a compaction has been done
> 
> When a System.gc() is done with -XX:-UseCMSCompactAtFullCollection, a 
> mark-sweep
> without compaction is done.  In that instance the call to 
> reset_after_compaction() is
> not appropriate.
> 
> This changeset is built on top of the changeset for 8013032
> 
> http://cr.openjdk.java.net/~jmasa/8013184/webrev.00/


Minor: in the test, instead of hardcoding the class name to call, maybe
you could use something like ThreePlusMSSystemGC.class.getName()
instead.

Hth,
Thomas


[prev in list] [next in list] [prev in thread] [next in thread]