[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-gc-dev
Subject:    Request for review (XS): 7156764 Remove unused size parameter from some CollectedHeap methods
From:       bengt.rutisson () oracle ! com (Bengt Rutisson)
Date:       2012-03-27 10:41:52
Message-ID: 4F719970.5060508 () oracle ! com
[Download RAW message or body]


Hi all,

I got reviews from Tony and Jesper, so I'm all set to push this. Thanks 
Tony and Jesper!

Bengt


On 2012-03-27 09:36, Bengt Rutisson wrote:
>
> Hi again,
>
> An updated webrev. Only updated the comment for 
> next_gc_should_be_mixed() based on feedback from Tony:
> http://cr.openjdk.java.net/~brutisso/7156764/webrev.01/
>
> Bengt
>
> On 2012-03-26 11:27, Bengt Rutisson wrote:
>>
>> Hi all,
>>
>> Can I have a couple of reviews for this small cleanup?
>> http://cr.openjdk.java.net/~brutisso/7156764/webrev.00/
>>
>> I removed an unused size parameter from some of the methods in 
>> CollectedHeap. I also bundle two other minor cleanups:
>>
>> - The comment for G1CollectorPolicy::next_gc_should_be_mixed() needs 
>> an update
>> - The declaration of CollectedHeap::initialize_heap_log() is not needed
>>
>> Ideally I would have liked to separate these changes out, but it is 
>> just too much overhead given the small size of the changes.
>>
>> Thanks,
>> Bengt
>


[prev in list] [next in list] [prev in thread] [next in thread]