[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-dev
Subject:    Re: RFR: 8297600: Check current thread in selected JRT_LEAF methods [v2]
From:       Aleksey Shipilev <shade () openjdk ! org>
Date:       2022-11-30 9:08:16
Message-ID: EFZuFhFCuSAoy1ynwnKgMY3y2ZcVXkp6z2UuDXD4lcA=.436f11a2-47d0-4c8b-b03c-a158b0c71e35 () github ! com
[Download RAW message or body]

On Mon, 28 Nov 2022 12:26:41 GMT, Aleksey Shipilev <shade@openjdk.org> wrote:

> > With [JDK-8275286](https://bugs.openjdk.org/browse/JDK-8275286), we added the \
> > `Thread::current()` checks for most of the JRT entries. But `JRT_LEAF` is still \
> > not checked, because not every `JRT_LEAF` carries a `JavaThread` argument. Having \
> > assertions there helps for two reasons. First, these methods can be called from \
> > the stub/compiler code, which might be erroneous with thread handling (especially \
> > in x86_32 that does not have a dedicated thread register). Second, in the \
> > post-Loom world, current thread can change suddenly, as evidenced here: \
> > https://mail.openjdk.org/pipermail/hotspot-compiler-dev/2022-November/060779.html.
> >  
> > We can add the thread checks to relevant `JRT_LEAF` methods that accept \
> > `JavaThread*` too. 
> > Additional testing:
> > - [x] Linux x86_64 fastdebug `tier1`
> > - [x] Linux x86_64 fastdebug `tier2`
> > - [x] Linux x86_32 fastdebug `tier1`
> > - [x] Linux x86_32 fastdebug `tier2`
> 
> Aleksey Shipilev has updated the pull request incrementally with one additional \
> commit since the last revision: 
> Revert some additions

Thanks! I am integrating then.

-------------

PR: https://git.openjdk.org/jdk/pull/11359


[prev in list] [next in list] [prev in thread] [next in thread]