[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-dev
Subject:    Re: [15] RFR (M): 8238681: Make -XX:UseSSE flag x86-specific
From:       Vladimir Ivanov <vladimir.x.ivanov () oracle ! com>
Date:       2020-02-18 12:40:46
Message-ID: 9eecf8a9-90bf-2d75-a960-0eba1fc90d3c () oracle ! com
[Download RAW message or body]

Thanks for the reviews, David and Vladimir.

Best regards,
Vladimir Ivanov

On 18.02.2020 15:39, David Holmes wrote:
> +1
> 
> Thanks,
> David
> 
> On 15/02/2020 3:44 am, Vladimir Kozlov wrote:
>> I am fine with -XX:+IgnoreUnrecognizedVMOptions. I am for testing on 
>> more platforms ;)
>>
>> Thanks,
>> Vladimir K
>>
>> On 2/14/20 8:10 AM, Vladimir Ivanov wrote:
>>> Thanks for the feedback, Vladimir.
>>>
>>>> compiler/c1/Test6579789.java and compiler/c1/Test6855215.java use 
>>>> UseSSE flag without @requires.
>>>
>>> Good catch. But I'm not sure @requires [1] is the best option here:
>>>
>>>     * -XX:UseSSE=0 has any effect only on x86-32;
>>>
>>>     * both bugs were reported against x86-32, but at least 6579789 is 
>>> not platform-specific. So it makes sense to run the tests on other 
>>> platforms.
>>>
>>> So, I'd prefer to use -XX:+IgnoreUnrecognizedVMOptions instead. 
>>> What's your take on it?
>>>
>>> Best regards,
>>> Vladimir Ivanov
>>>
>>> [1]
>>> diff --git a/test/hotspot/jtreg/compiler/c1/Test6579789.java 
>>> b/test/hotspot/jtreg/compiler/c1/Test6579789.java
>>> --- a/test/hotspot/jtreg/compiler/c1/Test6579789.java
>>> +++ b/test/hotspot/jtreg/compiler/c1/Test6579789.java
>>> @@ -26,6 +26,8 @@
>>>    * @bug 6579789
>>>    * @summary Internal error "c1_LinearScan.cpp:1429 Error: 
>>> assert(false,"")" in debuggee with fastdebug VM
>>>    *
>>> + * @requires os.arch=="i386"
>>> + *
>>>    * @run main/othervm -Xcomp -XX:UseSSE=0
>>>    *      -XX:CompileCommand=compileonly,compiler.c1.Test6579789::bug
>>>    *      compiler.c1.Test6579789
>>> diff --git a/test/hotspot/jtreg/compiler/c1/Test6855215.java 
>>> b/test/hotspot/jtreg/compiler/c1/Test6855215.java
>>> --- a/test/hotspot/jtreg/compiler/c1/Test6855215.java
>>> +++ b/test/hotspot/jtreg/compiler/c1/Test6855215.java
>>> @@ -26,6 +26,8 @@
>>>    * @bug 6855215
>>>    * @summary Calculation error (NaN) after about 1500 calculations
>>>    *
>>> + * @requires os.arch=="i386"
>>> + *
>>>    * @run main/othervm -Xbatch -XX:UseSSE=0 compiler.c1.Test6855215
>>>    */
>>>
>>>
>>>>
>>>> Otherwise changes seems good.
>>>>
>>>> Thanks,
>>>> Vladimir
>>>>
>>>> On 2/10/20 6:19 AM, Vladimir Ivanov wrote:
>>>>> http://cr.openjdk.java.net/~vlivanov/8238681/webrev.00/
>>>>> https://bugs.openjdk.java.net/browse/JDK-8238681
>>>>>
>>>>> Turn UseSSE into x86-specific flag since it doesn't have any 
>>>>> meaning on non-x86 platforms.
>>>>>
>>>>> As a cleanup, I made all the code which assumes UseSSE<2 x86-32 
>>>>> specific. (x86-64 ABI requires SSE2.)
>>>>>
>>>>> Also, as a precaution, I made UseSSE obsolete on non-x86 platforms.
>>>>>
>>>>> Testing: hs-precheckin-comp, tier1-5, linux x86-32 fastdebug build.
>>>>>
>>>>> Thanks!
>>>>>
>>>>> Best regards,
>>>>> Vladimir Ivanov
[prev in list] [next in list] [prev in thread] [next in thread]