[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-dev
Subject:    Re: RFR (XS) 8238909: x86_32 fails gtest:power_of_2
From:       Aleksey Shipilev <shade () redhat ! com>
Date:       2020-02-13 16:07:12
Message-ID: 7c4388cb-caa1-71a1-fef9-9f31d7a393ea () redhat ! com
[Download RAW message or body]

On 2/13/20 12:04 PM, Claes Redestad wrote:
> On 2020-02-12 21:30, Aleksey Shipilev wrote:
>> On 2/12/20 7:45 PM, Aleksey Shipilev wrote:
>>> Bug:
>>>    https://bugs.openjdk.java.net/browse/JDK-8238909
>>>
>>> Fix:
>>>    https://cr.openjdk.java.net/~shade/8238909/webrev.01/
>>
>> Scratch that, Stefan suggested a cleaner version:
>>    https://cr.openjdk.java.net/~shade/8238909/webrev.02/
> 
> Looks good, and nice catch. The use of is_power_of_2 was carried
> forward from a z-only helper method that is 64-bit only, so we all
> missed that it might be problematic on 32-bit.

Thanks, pushed.

-- 
Thanks,
-Aleksey

[prev in list] [next in list] [prev in thread] [next in thread]