[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-dev
Subject:    Re: RFR: 8229836: Remove include of globals.hpp from allocation.hpp
From:       Stefan Karlsson <stefan.karlsson () oracle ! com>
Date:       2019-08-26 7:13:02
Message-ID: 990f3d01-0065-ecc1-1a42-925440fd056c () oracle ! com
[Download RAW message or body]

Thanks for reviewing.

StefanK

On 2019-08-20 18:08, Kim Barrett wrote:
> > On Aug 20, 2019, at 8:09 AM, Stefan Karlsson <stefan.karlsson@oracle.com> wrote:
> > 
> > Hi all,
> > 
> > Please review this patch to remove the include of globals.hpp from \
> > allocation.hpp. 
> > http://cr.openjdk.java.net/~stefank/8229836/webrev.01/
> > https://bugs.openjdk.java.net/browse/JDK-8229836
> > 
> > Note this change is just the bare minimum to get it to compile on our build \
> > platforms. I haven't tried to find all files that are missing explicit includes \
> > of globals.hpp. 
> > Thanks,
> > StefanK
> 
> Looks good.
> 
> ------------------------------------------------------------------------------
> src/hotspot/share/oops/oopsHierarchy.hpp
> 76 extern "C" bool CheckUnhandledOops;
> 
> Huh! I hadn't realized options polluted the global C namespace. Yet
> another reason to have far fewer :)
> 
> ------------------------------------------------------------------------------
> 


[prev in list] [next in list] [prev in thread] [next in thread]