[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-dev
Subject:    Re: [14] RFR(S): 8193042: NativeLookup::lookup_critical_entry() should only load shared library once
From:       David Holmes <david.holmes () oracle ! com>
Date:       2019-07-30 20:42:48
Message-ID: 82ba405f-16fe-9b57-0476-1c89910ad0da () oracle ! com
[Download RAW message or body]

Hi Christian,

On 30/07/2019 10:47 pm, Christian Hagedorn wrote:
> Hi David, hi Dean
> 
> Thanks for your reviews!
> 
> 
> On 30.07.19 00:56, David Holmes wrote:
> > There are a few inherited style nits (missing braces on if-blocks) but
> > not worth pointing out as that code contains a lot of them.
> 
> I fixed the style issues where I touched the code. I updated the webrev:
> http://cr.openjdk.java.net/~thartmann/8193042/webrev.01/

Thanks for doing that - looks good.

> 
> On 30.07.19 07:13, Tobias Hartmann wrote:
> > 
> > On 30.07.19 00:56, David Holmes wrote:
> > > What testing did you do for this? (I'm not sure which tests would 
> > > exercise this code.)
> > 
> > I think besides the regular tiers, the test(s) referenced in 
> > JDK-8191360 should be suitable.
> 
> I tested it with hs-precheckin-comp,hs-tier1,2 and 3. hs-tier1 includes 
> [1] which uses this code for a critical native lookup.

Okay thanks.

David
-----

> Best regards,
> Christian
> 
> 
> [1] 
> http://hg.openjdk.java.net/jdk/jdk/file/144585063bc8/test/hotspot/jtreg/compiler/runtime/criticalnatives/lookup \
>  


[prev in list] [next in list] [prev in thread] [next in thread]