[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-dev
Subject:    Re: RFR: 8210131: vmTestbase/nsk/jvmti/scenarios/allocation/AP10/ap10t001/TestDescription.java
From:       Kim Barrett <kim.barrett () oracle ! com>
Date:       2018-08-31 17:50:38
Message-ID: F850183A-314C-4E49-90EA-65FEB9B7B901 () oracle ! com
[Download RAW message or body]

> On Aug 31, 2018, at 10:19 AM, Daniel D. Daugherty <daniel.daugherty@oracle.com> wrote:
> 
> On 8/30/18 10:15 PM, Kim Barrett wrote:
>> CR:
>> https://bugs.openjdk.java.net/browse/JDK-8210131
>> 
>> Webrev:
>> http://cr.openjdk.java.net/~kbarrett/8210131/open.00/
> 
> src/hotspot/share/prims/jvmtiEnter.xsl
>     No comments.
> 
> test/hotspot/jtreg/ProblemList.txt
>     No comments.
> 
> 
> I verified that the XSL changes will only affect the two functions
> in question: jvmti_GetCurrentThreadCpuTimerInfo() and
> jvmti_GetCurrentThreadCpuTime(). Unfortunately, I can't remember
> why that bit of XSL code only applies to those two functions.

Yeah, the language and code generation here are all pretty opaque to me.
Fortunately, I haven't needed to do anything significant to this code.

> In any case, thumbs up!

Thanks.

> Dan
> 
> 
>> 
>> Testing:
>> mach5 tier1-3, hs-tier4-6.
>> Local (linux-x64) jtreg:hotspot_gc, and manually ran the failing test.
>> Examined the generated jvmtiEnter[Trace].cpp file and verified the
>> change to the generated code was as expected.


[prev in list] [next in list] [prev in thread] [next in thread]