[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-dev
Subject:    Re: RFR(XS): 8209915: Fix license headers
From:       Doug Simon <doug.simon () oracle ! com>
Date:       2018-08-25 6:28:26
Message-ID: 68945E72-154F-495F-BC21-218DFA59F207 () oracle ! com
[Download RAW message or body]



> On 24 Aug 2018, at 20:33, Vladimir Kozlov <vladimir.kozlov@oracle.com> wrote:
> 
> I don't know why this JVMCI file in OpenJDK don't have license header. Lab's \
> version has it: 
> https://github.com/graalvm/graal-jvmci-8/blob/master/jvmci/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotMethodDataAccessor.java
>  
> Doug, do you know?

No, sorry.

-Doug

> 
> It also don't have empty line.
> 
> Regards,
> Vladimir
> 
> On 8/24/18 11:15 AM, Mikael Vidstedt wrote:
> > > On Aug 23, 2018, at 11:34 PM, Per Liden <per.liden@oracle.com> wrote:
> > > 
> > > On 08/23/2018 11:34 PM, Mikael Vidstedt wrote:
> > > > Please review this small change which fixes the license headers in three \
> > > > files: src/hotspot/share/memory/metaspace/virtualSpaceList.cpp
> > > > src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotMethodDataAccessor.java
> > > >  src/jdk.jfr/share/classes/jdk/jfr/internal/OldObjectSample.java
> > > > Bug: https://bugs.openjdk.java.net/browse/JDK-8209915
> > > > Webrev: http://cr.openjdk.java.net/~mikael/webrevs/8209915/webrev.00/open/webrev/
> > > > 
> > > 
> > > Looks good.
> > > 
> > > I guess it a space between line 22 and 23 in HotSpotMethodDataAccessor.java \
> > > wouldn't hurt, but I don't need to see a new webrev for that.
> > Vladimir/Per, thanks for the reviews!
> > I actually did add en empty line after the license header in \
> > HotSpotMethodDataAccessor.java at first, but then I noticed that all the other \
> > files in that directory except one \
> > (src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/CompilerToVM.java) \
> > lack that empty line, so for consistency reasons I decided to not add it after \
> > all. Cheers,
> > Mikael


[prev in list] [next in list] [prev in thread] [next in thread]