[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-dev
Subject:    Re: Moving the _vtable_len into Klass
From:       John Rose <john.r.rose () oracle ! com>
Date:       2015-12-18 10:33:37
Message-ID: C94D888F-0910-4F76-98D8-D7A7A06367A8 () oracle ! com
[Download RAW message or body]

On Dec 17, 2015, at 6:29 AM, Mikael Gerdin <mikael.gerdin@oracle.com> wrote:
> 
> My current plan is to first modify the vtable_length_offset accessor to return a \
> byte offset (which is what it's translated to by all callers). 
> Then I'll tackle moving the _vtable_len field to Klass.
> 
> Finally I'll try to consolidate the vtable related methods to Klass, where they \
> belong. 
> The vtable_start_offset is a slightly more difficult beast since it's more often \
> used in wordSize scaled calculations, my current idea is to leave it alone for now. \
>  Does that sound like a good plan?

Sure, that's fine.  It might be slightly better if you could make vtable_start_offset \
also be unscaled, but (as I said) that's more of a long-term goal, to move towards \
unscaled offset calculations.

— John=


[prev in list] [next in list] [prev in thread] [next in thread]