[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-dev
Subject:    RE: RFR(S): 8130036: Fix problems with imprecise C++ coding.
From:       "Lindenmaier, Goetz" <goetz.lindenmaier () sap ! com>
Date:       2015-06-30 7:28:28
Message-ID: 4295855A5C1DE049A61835A1887419CC2D000E9C () DEWDFEMB12A ! global ! corp ! sap
[Download RAW message or body]

Hi David, 

thanks for pushing it!

Best regards,
  Goetz.

-----Original Message-----
From: David Holmes [mailto:david.holmes@oracle.com] 
Sent: Montag, 29. Juni 2015 11:26
To: Lindenmaier, Goetz; HotSpot Developers
Cc: Zeller, Arno
Subject: Re: RFR(S): 8130036: Fix problems with imprecise C++ coding.

Hi Goetz,

Good catches! If no-one steps in overnight I'll take care of this in my 
morning.

Thanks,
David

On 29/06/2015 6:30 PM, Lindenmaier, Goetz wrote:
> Hi,
>
>
>
> We detected some minor, but obviously wrong coding issues we would like to fix.
>
>
>
> In two places {} are missing after an if, whilst there are two statements that depend
>
> on the condition (CHECK macro expands to another statement).
>
>
>
> In compilerOracle.cpp, a wrong size is passed to jio_snprintf().
>
>
>
> Please review this change.  I please need a sponsor.
>
> http://cr.openjdk.java.net/~goetz/webrevs/8130036_blocks/webrev.01/8130036_blocks-hs-rt.changeset
>
>
>
> Best regards,
>
>    Goetz.
>
> Sorry for the resend, the subject was missing ...
>
[prev in list] [next in list] [prev in thread] [next in thread]