[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-dev
Subject:    Re: RFR(S): 8129757: ppc/aarch: Fix passing thread to runtime after "8073165: Contended Locking fast
From:       "Daniel D. Daugherty" <daniel.daugherty () oracle ! com>
Date:       2015-06-24 15:57:02
Message-ID: 558AD34E.8070703 () oracle ! com
[Download RAW message or body]

On 6/24/15 1:40 AM, Lindenmaier, Goetz wrote:
> Hi,
> 
> Change 8073165 added a new argument to complete_monitor_unlocking_C(): the current \
> thread. Moving this value into the argument registers before the runtime call \
> issued in the native wrapper was missing on ppc and aarch. 
> Please review this change:
> http://cr.openjdk.java.net/~goetz/webrevs/8129757-unlock/webrev-01/

src/cpu/aarch64/vm/sharedRuntime_aarch64.cpp
     L2132     rt_call(masm, CAST_FROM_FN_PTR(address, 
SharedRuntime::complete_monitor_unlocking_C), 3, 0, 1);

         nit: It would nice if there was comment like above L2132:

         // Arguments are (oop obj, BasicLock* lock, JavaThread* thread).

src/cpu/ppc/vm/sharedRuntime_ppc.cpp
     No comments.

Thumbs up.

Dan


> 
> Edward Nevill already had a look at the aarch changes and tested them.
> 
> Best regards,
> Goetz.


[prev in list] [next in list] [prev in thread] [next in thread]