[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-compiler-dev
Subject:    Re: RFR: 8328998: Encoding support for Intel APX extended general-purpose registers [v22]
From:       Steve Dohrmann <duke () openjdk ! org>
Date:       2024-05-17 17:52:32
Message-ID: cC5kzIs0ROs_GuAyQn2lYaGiTf0IQt5335cEVBHlvkc=.907ddb41-c95b-436f-9604-216451194f3e () github ! com
[Download RAW message or body]

On Fri, 17 May 2024 09:47:22 GMT, Jatin Bhateja <jbhateja@openjdk.org> wrote:

> > Steve Dohrmann has updated the pull request incrementally with one additional \
> > commit since the last revision: 
> > simplify test in new asserts to just assert UseAPX
> 
> src/hotspot/cpu/x86/vm_version_x86.cpp line 1005:
> 
> > 1003:   }
> > 1004: 
> > 1005:   if (UseAPX && (UseAVX < 3)) {
> 
> A comment here will be helpful stating the need to disable APX functionality for \
> non AVX512 targets, please note UseAVX is set to level 3 based on existence of \
> CPUID (EAX=07, EBX[16] = AVX512F) bit, and future AVX10 targets may support APX.

Thanks.  I added a comment.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18476#discussion_r1605370071


[prev in list] [next in list] [prev in thread] [next in thread]