[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-compiler-dev
Subject:    Re: RFR: 8323795: jcmd Compiler.codecache should print total size of code cache [v5]
From:       Vladimir Kozlov <kvn () openjdk ! org>
Date:       2024-01-30 17:29:34
Message-ID: tCWYjEljz2kruWwtZKnf1nLGfnO9cfGJNvQHxlu7E-4=.a28fcacc-6460-4cc9-a41f-8afc940a7f7b () github ! com
[Download RAW message or body]

On Tue, 30 Jan 2024 06:49:57 GMT, Yi Yang <yyang@openjdk.org> wrote:

>> CodeHeap 'non-profiled nmethods': size=118592Kb used=29Kb max_used=29Kb free=118562Kb
>>  bounds [0x00007fbe84622000, 0x00007fbe84892000, 0x00007fbe8b9f2000]
>> CodeHeap 'profiled nmethods': size=118588Kb used=80Kb max_used=80Kb free=118507Kb
>>  bounds [0x00007fbe7c9f2000, 0x00007fbe7cc62000, 0x00007fbe83dc1000]
>> CodeHeap 'non-nmethods': size=8580Kb used=1258Kb max_used=1834Kb free=7321Kb
>>  bounds [0x00007fbe83dc1000, 0x00007fbe84031000, 0x00007fbe84622000]
>>  total_blobs=474 nmethods=87 adapters=293
>>  compilation: enabled
>>               stopped_count=0, restarted_count=0
>>  full_count=0
>> 
>> 
>> It's better to accumulates total size of used/free/size, for example
>> 
>> -SegmentedCodeCache
>> CodeCache: size=245760Kb used=1366Kb max_used=1943Kb free=244393Kb
>>  bounds [0x00007fdcc89f2000, 0x00007fdcc8c62000, 0x00007fdcd79f2000]
>>  total_blobs=474, nmethods=87, adapters=293
>>  stopped_count=0, restarted_count=0, full_count=0 
>>  compilation=enabled
>> 
>> 
>> 
>> +SegmentedCodeCache
>> CodeHeap 'non-profiled nmethods': size=118592Kb used=29Kb max_used=29Kb free=118562Kb
>>  bounds [0x00007f89c8622000, 0x00007f89c8892000, 0x00007f89cf9f2000]
>> CodeHeap 'profiled nmethods': size=118588Kb used=80Kb max_used=80Kb free=118507Kb
>>  bounds [0x00007f89c09f2000, 0x00007f89c0c62000, 0x00007f89c7dc1000]
>> CodeHeap 'non-nmethods': size=8580Kb used=1258Kb max_used=1834Kb free=7321Kb
>>  bounds [0x00007f89c7dc1000, 0x00007f89c8031000, 0x00007f89c8622000]
>> CodeCache: size=245760Kb, used=1367Kb, max_used=1943Kb, free=244390Kb
>>  total_blobs=474, nmethods=87, adapters=293
>>  stopped_count=0, restarted_count=0, full_count=0 
>>  compilation=enabled
>
> Yi Yang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fix ident && vmTestbase test

The output looks fine to me now. I approve but it needs new round of testing.

-------------

Marked as reviewed by kvn (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17445#pullrequestreview-1851931838
[prev in list] [next in list] [prev in thread] [next in thread]