[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-compiler-dev
Subject:    Re: RFR: 8305637: Remove Opaque1 nodes for Parse Predicates and clean up useless predicate eliminati
From:       Roland Westrelin <roland () openjdk ! org>
Date:       2023-08-31 16:02:10
Message-ID: KXBztRWAfFnnwe0M5191stsGRo-e09zM-Rb5h-oBBJ4=.cf9b1c02-1987-4d53-a939-f6d5d60bd14b () github ! com
[Download RAW message or body]

On Thu, 31 Aug 2023 12:50:35 GMT, Christian Hagedorn <chagedorn@openjdk.org> wrote:

> > This is the last clean-up PR before the complete fix for Assertion Predicates \
> > ([JDK-8288981](https://bugs.openjdk.org/browse/JDK-8288981)).  
> > This patch includes:
> > - Removal of `ConI`->`Opaque1`->`Conv2B` input nodes for `ParsePredicateNodes` \
> >                 with the following additional changes:
> > - Adjusting `ParsePredicateNode` to block unwanted optimizations (added empty \
> >                 `ParsePredicateNode::Ideal()`).
> > - Changing `Compile::_parse_predicate_opaqs` to not store `Opaque1Nodes` to keep \
> > track of Parse Predicates but instead storing `ParsePredicateNodes` directly. \
> >                 Renamed to `Compile::_parse_predicates` and adjusted related \
> >                 methods.
> > - Removed asserts matching `Opaque1` -> `Conv2B` shape.
> > - Cleaning up `eliminate_useless_predicates()`:
> > - Adjust code to find useful/useless Parse Predicates with the new \
> > `Compile::_parse_predicates` list with `ParsePredicateNodes` instead of \
> >                 `Opaque1Nodes`.
> > - Changing `ParsePredicateNode` to carry a `_useless` state which simplifies the \
> > elimination of useless predicates with `eliminate_useless_predicates()` and \
> > during IGVN (added `ParsePredicateNode::Value()` for that which also removes the \
> >                 predicate once we are in post loop opts IGVN). 
> > - Some refactoring/clean-ups of involved code.
> > 
> > Testing: tier1-7 + some fuzzer testing
> > 
> > Thanks,
> > Christian
> 
> Christian Hagedorn has updated the pull request incrementally with one additional \
> commit since the last revision: 
> Clean up is_uncommon_trap_if_pattern(), is_uncommon_trap_proj(), variable names, \
> and types.

Update looks good to me. Thanks for making the change.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15449#issuecomment-1701312424


[prev in list] [next in list] [prev in thread] [next in thread]