[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-compiler-dev
Subject:    Integrated: 8309697: [TESTBUG] Remove "@requires vm.flagless" from jtreg vectorization tests
From:       Pengfei Li <pli () openjdk ! org>
Date:       2023-08-29 1:43:20
Message-ID: 0IykzlU0Q3dpYsYgLVsItV5_CJ1t2RG67rJvYzm62_s=.b025f558-aa5a-4525-9b36-ce71f08636f7 () github ! com
[Download RAW message or body]

On Tue, 25 Jul 2023 08:35:11 GMT, Pengfei Li <pli@openjdk.org> wrote:

> This patch removes `@require vm.flagless` annotations from HotSpot jtreg tests in \
> `compiler/vectorization/runner`. All jtreg cases in this folder are invoked by test \
> driver `VectorizationTestRunner.java` which checks both correctness and \
> vectorizability (IR) for each test method. We added flagless requirement before \
> because extra flags may mess with compiler control in the test driver for \
> correctness check. But `flagless` has a side effect that it makes tests with extra \
> flags skipped. So we propose to get rid of it now. 
> To adapt the removal of `@require vm.flagless`, a few checks are added in the test \
> driver to skip the correctness check if extra flags make the compiler control not \
> work. This patch also moves previously hard-coded flag `-XX:-OptimizeFill` in the \
> test driver to conditions in IR checks. 
> Tested various of compiler control related VM flags on x86 and AArch64.

This pull request has now been integrated.

Changeset: a03954e6
Author:    Pengfei Li <pli@openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/a03954e6c57369446ef77136966662780e4b1c4e
                
Stats:     77 lines in 23 files changed: 31 ins; 16 del; 30 mod

8309697: [TESTBUG] Remove "@requires vm.flagless" from jtreg vectorization tests

Reviewed-by: kvn, thartmann, epeter, chagedorn

-------------

PR: https://git.openjdk.org/jdk/pull/15011


[prev in list] [next in list] [prev in thread] [next in thread]