[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-compiler-dev
Subject:    Integrated: 8314513: [IR Framework] Some internal IR Framework tests are failing after JDK-8310308 o
From:       Christian Hagedorn <chagedorn () openjdk ! org>
Date:       2023-08-28 10:34:18
Message-ID: 5gWktDX8v-T6mEf6R6mEkzs21SL_kQjU2RKlO_L4k3U=.59731871-cb99-40ea-b9a1-b269f804973c () github ! com
[Download RAW message or body]

On Thu, 24 Aug 2023 11:51:11 GMT, Christian Hagedorn <chagedorn@openjdk.org> wrote:

> This patch fixes some internal IR framework failures after \
>                 [JDK-8310308](https://bugs.openjdk.org/browse/JDK-8310308):
> - `testlibrary_tests/ir_framework/tests/TestBadFormat.java` on Linux ppc64le:
> - `applyIfCPUFeature` clauses are false and the rule is not run. We will therefore \
> not hit the format violations which the test expects to find. The fix here is to \
> remove the `applyIfCPUFeature` constraints as the test is only interested in \
>                 properly reporting format violations.
> - `testlibrary_tests/ir_framework/examples/IRExample.java` on Cascade Lake x86_64:
> - On Cascade Lake, `failOn` constraints need the same "always true" handling as \
> `counts` constraints. This was missed in JDK-8310308. I've added the same \
> `try-catch` handling as in `RawCountsConstraint::parse()`: \
> https://github.com/openjdk/jdk/blob/97b94cb1cdeba00f4bba7326a300c0336950f3ec/test/ho \
> tspot/jtreg/compiler/lib/ir_framework/driver/irmatching/irrule/constraint/raw/RawCountsConstraint.java#L97-L104
>  
> Thanks to @MBaesken and @TheRealMDoerr for reporting this and helping with some \
> pre-PR testing. Would you like to rerun your testing on PPC and Cascade Lake again? \
>  Thanks,
> Christian

This pull request has now been integrated.

Changeset: 5c4f1dc4
Author:    Christian Hagedorn <chagedorn@openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/5c4f1dc43ebd1ad699923e0082cfed72ba414982
                
Stats:     30 lines in 2 files changed: 5 ins; 12 del; 13 mod

8314513: [IR Framework] Some internal IR Framework tests are failing after \
JDK-8310308 on PPC and Cascade Lake

Reviewed-by: kvn, mdoerr

-------------

PR: https://git.openjdk.org/jdk/pull/15415


[prev in list] [next in list] [prev in thread] [next in thread]