[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-compiler-dev
Subject:    Re: RFR: 8278016: Add compiler tests to tier{2,3} [v2]
From:       Vladimir Kozlov <kvn () openjdk ! java ! net>
Date:       2021-11-30 21:01:08
Message-ID: vsn3Lzb4-fp83nue6g4A7z0ywCZ9L2j4kVJscI-OfRY=.020e4453-ff85-4dc4-9a14-2bd50ef57acd () github ! com
[Download RAW message or body]

On Tue, 30 Nov 2021 20:44:43 GMT, Aleksey Shipilev <shade@openjdk.org> wrote:

> > I have been looking at `hotspot:tier4` (catch-all not in lower tiers) run logs, \
> > and realized the whole bunch of compiler tests are running there. 
> > Since `hotspot:tier4` runs a lot of `vmTestbase` tests, contributors seldom run \
> > it, as it takes many hours. Which means that many compiler tests are not running \
> > regularly for many contributors. But these tests are rather fast themselves and \
> > cover important compiler features. 
> > We can properly add compiler tests to `tier{2,3}` to expose them on earlier \
> > tiers. The split logic between tiers is roughly: fast feature tests go into \
> > tier2, slower feature tests and debugging/printing stuff goes to tier3. 
> > Sample times for new subgroups (think about this as "How much time they add to \
> > existing tiers"): 
> > 
> > ==============================
> > Test summary
> > ==============================
> > TEST                                              TOTAL  PASS  FAIL ERROR   
> > jtreg:test/hotspot/jtreg:tier2_compiler             243   243     0     0   
> > ==============================
> > 
> > real	2m16.518s
> > user	35m40.839s
> > sys	1m35.334s
> > 
> > ==============================
> > Test summary
> > ==============================
> > TEST                                              TOTAL  PASS  FAIL ERROR   
> > jtreg:test/hotspot/jtreg:tier3_compiler             132   132     0     0   
> > ==============================
> > 
> > real	4m31.935s
> > user	71m54.617s
> > sys	2m13.073s
> 
> Aleksey Shipilev has updated the pull request incrementally with one additional \
> commit since the last revision: 
> Filter out tier1/2 groups too

Looks good to me.

-------------

Marked as reviewed by kvn (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/6622


[prev in list] [next in list] [prev in thread] [next in thread]