[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-compiler-dev
Subject:    Re: RFR: 8277882: New subnode ideal optimization: converting "c0 - (x + c1)" into "(c0 - c1) - x" [v
From:       Dean Long <dlong () openjdk ! java ! net>
Date:       2021-11-30 1:31:15
Message-ID: NPVohmsHM1EbDuUIu1oBjua3VcWjMAl376r_QCy72Ss=.4e751990-9564-43bc-b5e6-571dfb9a8789 () github ! com
[Download RAW message or body]

On Mon, 29 Nov 2021 03:44:46 GMT, Zang, Zhiqiang <duke@openjdk.java.net> wrote:

> > Suggest two new optimizations that can be done in SubINode::Ideal.
> 
> Zang, Zhiqiang has updated the pull request incrementally with one additional \
> commit since the last revision: 
> clean.

Changes requested by dlong (Reviewer).

I think your tests need to check more cases, especially cases that use MIN_VALUE, \
MAX_VALUE, or otherwise cause underflow or overflow.

src/hotspot/share/opto/subnode.cpp line 197:

> 195:       jint c1 = phase->type(in2->in(2))->isa_int()->get_con();
> 196:       return new SubINode(phase->intcon(java_subtract(c0, c1)), in2->in(1));
> 197:   }

Should this code be checking for counted loops like below (see ok_to_convert)?

-------------

PR: https://git.openjdk.java.net/jdk/pull/6441


[prev in list] [next in list] [prev in thread] [next in thread]