[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-compiler-dev
Subject:    Integrated: 8277928: Fix compilation on macosx-aarch64 after 8276108
From:       Thomas Schatzl <tschatzl () openjdk ! java ! net>
Date:       2021-11-29 12:03:10
Message-ID: rnjMv_cM1Km6DujmXEpIihdofS-ZrSYQUmMVWsq8UB8=.9de1df4c-3ec4-49a9-8621-edb381988695 () github ! com
[Download RAW message or body]

On Mon, 29 Nov 2021 11:33:19 GMT, Thomas Schatzl <tschatzl@openjdk.org> wrote:

> Hi all,
> 
> can I have reviews for this change that uses a wrong format specifier for int64 \
> which makes osx/aarch64 builds fail. 
> [2021-11-29T10:42:32,638Z] \
> .../src/hotspot/cpu/aarch64/assembler_aarch64.hpp:482:41: error: format specifies \
> type 'long' but the argument has type 'int64_t' (aka 'long long') \
> [-Werror,-Wformat] [2021-11-29T10:42:32,638Z]                "must be, was: %ld, \
> %d", _offset, size); [2021-11-29T10:42:32,638Z]                               ~~~   \
> ^~~~~~~ [2021-11-29T10:42:32,638Z]                               %lld
> [2021-11-29T10:42:32,638Z] .../debug.hpp:65:36: note: expanded from macro 'assert'
> 
> 
> Instead of the hardcoded `%ld` the change uses `INT64_FORMAT`.
> 
> Testing: tier1 running, Gha
> 
> Thanks,
> Thomas

This pull request has now been integrated.

Changeset: 2622ab3f
Author:    Thomas Schatzl <tschatzl@openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/2622ab3fe94814fb4f7f22e4015ef1519e546905
                
Stats:     1 line in 1 file changed: 0 ins; 0 del; 1 mod

8277928: Fix compilation on macosx-aarch64 after 8276108

Reviewed-by: shade, dholmes

-------------

PR: https://git.openjdk.java.net/jdk/pull/6590


[prev in list] [next in list] [prev in thread] [next in thread]