[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-compiler-dev
Subject:    Re: RFR: 8276108: Wrong instruction generation in aarch64 backend [v2]
From:       Patric Hedlin <phedlin () openjdk ! java ! net>
Date:       2021-11-29 10:37:09
Message-ID: fy1yeAeCru1_z_EnMULgBzJ04CzlxAFJslbXjFTaQq8=.0566ef0b-2c30-48f8-91e6-1fb5261c354e () github ! com
[Download RAW message or body]

On Wed, 24 Nov 2021 11:52:45 GMT, Patric Hedlin <phedlin@openjdk.org> wrote:

> > C1 code generation on AArch64 may produce bad LDR/STR immediate offset \
> > instructions when the actual operand (datum) size is unknown. This change will \
> > alter the code generated for the problematic immediate offset to use the register \
> > offset version (requiring additional instructions). 
> > Contributed by Nick Gasson.
> > 
> > Added assert in Address::encode() to emphasise the use of a valid immediate (in \
> > base_plus_offset). 
> > Added clarifying comment to Address::offset_ok_for_immed() emphasising favouring \
> > of the scaled unsigned 12-bit encoding for aligned offsets.
> 
> Patric Hedlin has updated the pull request incrementally with one additional commit \
> since the last revision: 
> Clean-up address calculation via use of legitimize_address().

Thank you for reviewing @aph and @neliasso.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6212


[prev in list] [next in list] [prev in thread] [next in thread]