[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-compiler-dev
Subject:    Re: RFR: 8273416: C2: assert(false) failed: bad AD file after JDK-8252372 with UseSSE={0,1}
From:       Roland Westrelin <roland () openjdk ! java ! net>
Date:       2021-10-29 9:32:16
Message-ID: 9YO7f0X6xXeVEfSRrfvuX0G3el4u4UXnqoRMaoZPpJ4=.b892a615-4e8b-468e-bc30-fbd14aef65c0 () github ! com
[Download RAW message or body]

On Tue, 7 Sep 2021 10:10:08 GMT, Aleksey Shipilev <shade@openjdk.org> wrote:

> See the bug report for reproducer and failure message. I think the newly added \
> `CastDD`/`CastFF` nodes should handle the extended `regDPR`/`regFPR` (which \
> includes FPU "registers") instead of just `regD`/`regF` to avoid this mismatch \
> error when `UseSSE < 2`. 
> Unfortunately, we cannot just use `reg*PR` operands in existing match rules, \
> because those operands are defined as `UseSSE < 2`, and using them as operands and \
> `ideal_regs()` would break the matching on `UseSSE >= 2`. Therefore I had to add \
> another pair of matches. 
> Additonal testing:
> - [x] Linux x86_32 `tier1` `-XX:UseAVX=0 -XX:UseSSE=0`
> - [x] Linux x86_32 `tier1` default
> - [x] Linux x86_64 `tier1` default

Looks good to me.

-------------

Marked as reviewed by roland (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/5386


[prev in list] [next in list] [prev in thread] [next in thread]