[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-compiler-dev
Subject:    Re: [9] RFR(S): 8143081: [ctw] Test CompileTheWorld.java needs to be updated for Jigsaw
From:       Tatiana Pivovarova <tatiana.pivovarova () oracle ! com>
Date:       2016-06-27 13:32:17
Message-ID: 57712AE1.4040003 () oracle ! com
[Download RAW message or body]

Hi Igor!

Thanks for your review. I added these comments.
webrev : http://cr.openjdk.java.net/~tpivovarova/8143081/webrev.04/

Thanks,
Tatiana

On 06/24/2016 08:03 PM, Igor Ignatyev wrote:
> Hi Tatiana,
> 
> 1st of all, thanks for fixing that.
> 
> I've one suggest: could you please add a comment why we need to call System::exit \
> and store cout/cerr in CompileTheWorld.java? otherwise looks good to me. 
> Thanks,
> — Igor
> 
> > On Jun 23, 2016, at 8:19 PM, Tatiana Pivovarova <tatiana.pivovarova@oracle.com> \
> > wrote: 
> > Hi guys!
> > 
> > Please review this patch
> > 
> > To run CompileTheWorld harness with new jdk9 it is need to add compatibility to \
> > read .jimage files and to remove hardcoded links to rt.jar and \
> > "sun.boot.class.path" property. 
> > bug: https://bugs.openjdk.java.net/browse/JDK-8143081
> > webrev: http://cr.openjdk.java.net/~tpivovarova/8143081/webrev.01/
> > 
> > Tested locally by compilation lib/modules.
> > 
> > Thanks,
> > Tatiana
> > 


[Attachment #3 (text/html)]

<html>
  <head>
    <meta content="text/html; charset=utf-8" http-equiv="Content-Type">
  </head>
  <body bgcolor="#FFFFFF" text="#000000">
    <font face="Helvetica, Arial, sans-serif">Hi Igor!<br>
      <br>
      Thanks for your review. I added these comments.<br>
      webrev : <a class="moz-txt-link-freetext" \
href="http://cr.openjdk.java.net/~tpivovarova/8143081/webrev.04/">http://cr.openjdk.java.net/~tpivovarova/8143081/webrev.04/</a><br>
  <br>
      Thanks,<br>
      Tatiana<br>
    </font><br>
    <div class="moz-cite-prefix">On 06/24/2016 08:03 PM, Igor Ignatyev
      wrote:<br>
    </div>
    <blockquote
      cite="mid:6A4D519E-D2BE-46DA-96C3-A627E2A5B6C3@oracle.com"
      type="cite">
      <pre wrap="">Hi Tatiana,

1st of all, thanks for fixing that.

I've one suggest: could you please add a comment why we need to call System::exit and \
store cout/cerr in CompileTheWorld.java? otherwise looks good to me.

Thanks,
— Igor

</pre>
      <blockquote type="cite">
        <pre wrap="">On Jun 23, 2016, at 8:19 PM, Tatiana Pivovarova <a \
class="moz-txt-link-rfc2396E" \
href="mailto:tatiana.pivovarova@oracle.com">&lt;tatiana.pivovarova@oracle.com&gt;</a> \
wrote:

Hi guys!

Please review this patch

To run CompileTheWorld harness with new jdk9 it is need to add compatibility to read \
.jimage files and to remove hardcoded links to rt.jar and "sun.boot.class.path" \
property.

bug: <a class="moz-txt-link-freetext" \
href="https://bugs.openjdk.java.net/browse/JDK-8143081">https://bugs.openjdk.java.net/browse/JDK-8143081</a>
                
webrev: <a class="moz-txt-link-freetext" \
href="http://cr.openjdk.java.net/~tpivovarova/8143081/webrev.01/">http://cr.openjdk.java.net/~tpivovarova/8143081/webrev.01/</a>


Tested locally by compilation lib/modules.

Thanks,
Tatiana

</pre>
      </blockquote>
      <pre wrap="">
</pre>
    </blockquote>
    <br>
  </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic