[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-compiler-dev
Subject:    Re: [9] RFR 8072369: [TESTBUG] Remove potentially insecure class cast in some hotspot tests
From:       Konstantin Shefov <konstantin.shefov () oracle ! com>
Date:       2015-09-30 11:59:42
Message-ID: 560BCEAE.20800 () oracle ! com
[Download RAW message or body]

Kindly reminder

Please, review.

-Konstantin

On 09/09/2015 04:16 PM, Konstantin Shefov wrote:
> Description of the fix.
> Some tests in hotspot repo use class cast from Application class 
> loader to URLClassLoader, but Application class loader is not 
> guaranteed to be always an instance of a URLClassLoader.
> The tests should be changed so that they do not cast appclassloader to 
> URLClassLoader.
>
> -Konstantin
>
> On 09/08/2015 07:01 PM, Konstantin Shefov wrote:
>> Hello
>>
>> Please review a test bug fix.
>>
>> JBS entry: https://bugs.openjdk.java.net/browse/JDK-8072369
>> Webrev: http://cr.openjdk.java.net/~kshefov/8072369/webrev.00
>>
>> Thanks
>> -Konstantin
>


[Attachment #3 (text/html)]

<html>
  <head>
    <meta content="text/html; charset=utf-8" http-equiv="Content-Type">
  </head>
  <body text="#000000" bgcolor="#FFFFFF">
    Kindly reminder<br>
    <br>
    Please, review.<br>
    <br>
    -Konstantin<br>
    <br>
    <div class="moz-cite-prefix">On 09/09/2015 04:16 PM, Konstantin
      Shefov wrote:<br>
    </div>
    <blockquote cite="mid:55F0312E.7020908@oracle.com" type="cite">
      <meta content="text/html; charset=utf-8" http-equiv="Content-Type">
      Description of the fix.<br>
      <meta http-equiv="content-type" content="text/html; charset=utf-8">
      Some tests in hotspot repo use class cast from Application class
      loader to URLClassLoader, but Application class loader is not
      guaranteed to be always an instance of a URLClassLoader.<br>
      The tests should be changed so that they do not cast
      appclassloader to URLClassLoader.<br>
      <br>
      -Konstantin<br>
      <br>
      <div class="moz-cite-prefix">On 09/08/2015 07:01 PM, Konstantin
        Shefov wrote:<br>
      </div>
      <blockquote cite="mid:55EF0649.8050109@oracle.com" type="cite">Hello

        <br>
        <br>
        Please review a test bug fix. <br>
        <br>
        JBS entry: <a moz-do-not-send="true"
          class="moz-txt-link-freetext"
          href="https://bugs.openjdk.java.net/browse/JDK-8072369">https://bugs.openjdk.java.net/browse/JDK-8072369</a>
  <br>
        Webrev: <a moz-do-not-send="true" class="moz-txt-link-freetext"
          href="http://cr.openjdk.java.net/%7Ekshefov/8072369/webrev.00">http://cr.openjdk.java.net/~kshefov/8072369/webrev.00</a>
  <br>
        <br>
        Thanks <br>
        -Konstantin <br>
      </blockquote>
      <br>
    </blockquote>
    <br>
  </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic