[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-hotspot-compiler-dev
Subject: Re: About bug fix of 8010278
From: Kevin Walls <kevin.walls () oracle ! com>
Date: 2013-07-31 11:47:32
Message-ID: 51F8F954.6020704 () oracle ! com
[Download RAW message or body]
Hi Kris,
Yes, fixing the post-nashorn javascript issues is very welcome!... The
sa.js fix I mention is attached to bug 8011888 but not out for review
yet that I have seen. Maybe you want to ping the owner and decide which
fix should proceed...
I was just commenting that I couldn't reproduce the problem Yumin
reported in 8021444 due to those javascript issues in sa.js... So I
used the sa.js that was attached to 8011888 to get that working.
Trying your sa.js now: yes, that at least runs CLHSDB OK and e.g. the
ciReplay tests pass.
Thanks!
Kevin
On 31/07/13 08:54, Krystal Mok wrote:
> Hi Kevin,
>
> Just noticed this one. I wonder if the suggested sa.js fix is similar
> to the one I purposed here:
> http://mail.openjdk.java.net/pipermail/serviceability-dev/2013-July/010831.html
>
> Regards,
> Kris
>
>
> On Fri, Jul 26, 2013 at 5:20 PM, Kevin Walls <kevin.walls@oracle.com
> <mailto:kevin.walls@oracle.com>> wrote:
>
>
> Hi Yumin,
>
> Sure no problem I'll look into it. Looks like in ClassDump we
> should check classFilter != null before doing that initialisation
> in the run() method.
>
> At the moment trying jtreg on test/compiler/ciReplay I get a
> failure in TestSA.sh, as it calls sun.jvm.hotspot.CLHSDB, and
> gives the javascript exceptions characteristic of 8011888.
> Rebuilding with the suggested new sa.js I see in that bug, I'll
> test and let you know...
>
> Thanks!
> Kevin
>
>
>
>
> On 26/07/13 02:17, Yumin Qi wrote:
>
> Hi, Kevin
>
> http://cr.openjdk.java.net/~kevinw/8010278/webrev.03/
> <http://cr.openjdk.java.net/%7Ekevinw/8010278/webrev.03/>
> <http://cr.openjdk.java.net/%7Ekevinw/8010278/webrev.03/>
> I found this fix breaks C2 replay for dumping loaded java
> classes:
>
> at
> sun.jvm.hotspot.tools.jcore.PackageNameFilter.canInclude(PackageNameFilter.java:55)
> at
> sun.jvm.hotspot.tools.jcore.ClassDump.dumpKlass(ClassDump.java:135)
> at
> sun.jvm.hotspot.tools.jcore.ClassDump.access$000(ClassDump.java:38)
> at
> sun.jvm.hotspot.tools.jcore.ClassDump$1.visit(ClassDump.java:106)
> at
> sun.jvm.hotspot.memory.Dictionary.classesDo(Dictionary.java:68)
> at
> sun.jvm.hotspot.memory.SystemDictionary.classesDo(SystemDictionary.java:190)
> at
> sun.jvm.hotspot.tools.jcore.ClassDump.run(ClassDump.java:102)
> at
> sun.jvm.hotspot.DumpLoadedClasses.run(DumpLoadedClasses.java:65)
> at
> sun.jvm.hotspot.DumpLoadedClasses.main(DumpLoadedClasses.java:43)
>
> The problem is with Replay, we set BootFilter and
> NonBootFilter for ClassDump, but this changeset ignored the
> existing filter.
> I filed a bug against this problem.
>
> https://jbs.oracle.com/bugs/browse/JDK-8021444
>
> Thanks
> Yumin
>
>
>
>
[Attachment #3 (text/html)]
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#ffffff" text="#000000">
<br>
Hi Kris, <br>
<br>
Yes, fixing the post-nashorn javascript issues is very welcome!...
The sa.js fix I mention is attached to bug 8011888 but not out for
review yet that I have seen. Maybe you want to ping the owner and
decide which fix should proceed...<br>
<br>
I was just commenting that I couldn't reproduce the problem Yumin
reported in 8021444 due to those javascript issues in sa.js... So I
used the sa.js that was attached to 8011888 to get that working.<br>
<br>
Trying your sa.js now: yes, that at least runs CLHSDB OK and e.g.
the ciReplay tests pass.<br>
<br>
Thanks!<br>
Kevin<br>
<br>
<br>
On 31/07/13 08:54, Krystal Mok wrote:
<blockquote
cite="mid:CA+cQ+tRBGdV2PRCqeqp8EBm+YUSsiqLn5HR4qcULPtbFyk8kgw@mail.gmail.com"
type="cite">
<div dir="ltr">Hi Kevin,
<div><br>
</div>
<div style="">Just noticed this one. I wonder if the suggested
sa.js fix is similar to the one I purposed here:</div>
<div style=""><a moz-do-not-send="true"
href="http://mail.openjdk.java.net/pipermail/serviceability-dev/2013-July/010831.html" \
>http://mail.openjdk.java.net/pipermail/serviceability-dev/2013-July/010831.html</a><br>
>
</div>
<div style=""><br>
</div>
<div style="">Regards,</div>
<div style="">Kris</div>
</div>
<div class="gmail_extra"><br>
<br>
<div class="gmail_quote">On Fri, Jul 26, 2013 at 5:20 PM, Kevin
Walls <span dir="ltr"><<a moz-do-not-send="true"
href="mailto:kevin.walls@oracle.com" \
target="_blank">kevin.walls@oracle.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt
0.8ex; border-left: 1px solid rgb(204, 204, 204);
padding-left: 1ex;"><br>
Hi Yumin,<br>
<br>
Sure no problem I'll look into it. Looks like in ClassDump
we should check classFilter != null before doing that
initialisation in the run() method.<br>
<br>
At the moment trying jtreg on test/compiler/ciReplay I get a
failure in TestSA.sh, as it calls sun.jvm.hotspot.CLHSDB,
and gives the javascript exceptions characteristic of
8011888. Rebuilding with the suggested new sa.js I see in
that bug, I'll test and let you know...<br>
<br>
Thanks!<span class="HOEnZb"><font color="#888888"><br>
Kevin</font></span>
<div class="HOEnZb">
<div class="h5"><br>
<br>
<br>
<br>
On 26/07/13 02:17, Yumin Qi wrote:<br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt
0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204);
padding-left: 1ex;">
Hi, Kevin<br>
<br>
<a moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Ekevinw/8010278/webrev.03/"
target="_blank">http://cr.openjdk.java.net/~kevinw/8010278/webrev.03/</a>
<<a moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Ekevinw/8010278/webrev.03/"
target="_blank">http://cr.openjdk.java.net/%7Ekevinw/8010278/webrev.03/</a>><br>
I found this fix breaks C2 replay for dumping loaded
java classes:<br>
<br>
at \
sun.jvm.hotspot.tools.jcore.PackageNameFilter.canInclude(PackageNameFilter.java:55)<br>
at \
sun.jvm.hotspot.tools.jcore.ClassDump.dumpKlass(ClassDump.java:135)<br>
at \
sun.jvm.hotspot.tools.jcore.ClassDump.access$000(ClassDump.java:38)<br>
at \
sun.jvm.hotspot.tools.jcore.ClassDump$1.visit(ClassDump.java:106)<br>
at \
sun.jvm.hotspot.memory.Dictionary.classesDo(Dictionary.java:68)<br>
at \
sun.jvm.hotspot.memory.SystemDictionary.classesDo(SystemDictionary.java:190)<br>
at \
sun.jvm.hotspot.tools.jcore.ClassDump.run(ClassDump.java:102)<br>
at \
sun.jvm.hotspot.DumpLoadedClasses.run(DumpLoadedClasses.java:65)<br>
at \
sun.jvm.hotspot.DumpLoadedClasses.main(DumpLoadedClasses.java:43)<br> <br>
The problem is with Replay, we set BootFilter and
NonBootFilter for ClassDump, but this changeset
ignored the existing filter.<br>
I filed a bug against this problem.<br>
<br>
<a moz-do-not-send="true"
href="https://jbs.oracle.com/bugs/browse/JDK-8021444"
target="_blank">https://jbs.oracle.com/bugs/browse/JDK-8021444</a><br>
<br>
Thanks<br>
Yumin<br>
<br>
<br>
</blockquote>
<br>
</div>
</div>
</blockquote>
</div>
<br>
</div>
</blockquote>
<br>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic