[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-compiler-dev
Subject:    Request for reviews (M): 6930772: JSR 292 needs to support SPARC C1
From:       john.r.rose () oracle ! com (John Rose)
Date:       2010-04-28 19:23:31
Message-ID: 687EC090-C84C-440F-A8D0-EF60B653BF3F () oracle ! com
[Download RAW message or body]

Suggestion:  Grep for is_method_handle_adapter in this file, and adapt any relevant changes:

http://hg.openjdk.java.net/mlvm/mlvm/hotspot/file/tip/meth-ing-6939134.patch

(My bad that it's not pushed yet.)

-- John

On Apr 28, 2010, at 5:35 AM, Christian Thalinger wrote:

> On Wed, 2010-04-28 at 13:22 +0200, Christian Thalinger wrote:
>>> I think is_method_handle_invoke should be true only for the
>>> signature-polymorphic members of java.dyn.MethodHandle (invoke,
>>> eventually invokeGeneric/invokeExact).  We should have a different
>>> predicate (if we need it) for adapters.
>> 
>> Well, I think we need it, otherwise we don't inline them (from
>> InlineTree::shouldNotInline):
>> 
>>  // Always inline MethodHandle methods.
>>  if (callee_method->is_method_handle_invoke())
>>    return NULL;
>> 
>> Wait!  We have methodOopDesc::is_method_handle_adapter.  I think we
>> should add a check for that in the above statement and only return true
>> in ciMethod::is_method_handle_invoke as you suggested above.
> 
> That doesn't work.  I forgot that generated adapters for MH call sites
> are called java.dyn.MethodHandle::invoke and that fits the pattern of
> ciMethod::is_method_handle_invoke.  We need something else...
> 
> -- Christian
> 


[prev in list] [next in list] [prev in thread] [next in thread]