[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-compiler-dev
Subject:    Request reviews (S): 6902036: WorldWind asserts on escape.cpp:1153: assert(addr->is_AddP(),"AddP req
From:       Vladimir.Kozlov () Sun ! COM (Vladimir Kozlov)
Date:       2009-11-19 18:38:34
Message-ID: 4B0590AA.3070207 () sun ! com
[Download RAW message or body]

Thanks

Vladimir

Christian Thalinger wrote:
> On Wed, 2009-11-18 at 09:02 -0800, Vladimir Kozlov wrote:
>> http://cr.openjdk.java.net/~kvn/6902036/webrev.00
>>
>> Fixed 6902036: WorldWind asserts on escape.cpp:1153: assert(addr->is_AddP(),"AddP required")
>>
>> Problem:
>> AddPNode::Ideal() may replace AddP node with CastX2P node
>> for a raw memory reference. EA code does not check such case.
>>
>> Solution:
>> Check and ignore raw memory operations in EA.
> 
> Looks good to me.  At least I can tell that WorldWind works with that
> fix.
> 
> -- Christian
> 

[prev in list] [next in list] [prev in thread] [next in thread]