[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-compiler-dev
Subject:    Request for review (XS): 6893554: SPECjvm2008 mpegaudio fails with SecurityException
From:       Christian.Thalinger () Sun ! COM (Christian Thalinger)
Date:       2009-10-23 17:44:31
Message-ID: 1256319871.833.50.camel () macbook
[Download RAW message or body]

On Fri, 2009-10-23 at 10:35 -0700, Vladimir Kozlov wrote:
> I would just remove #ifdef and use extra shift always.
> One additional instruction will not affect performance but
> will guaranty the correctness since in 32-bit VM the upper
> bit of src register could be set also.

Good point.  I will remove the #ifdef and post another webrev.

> I looked on Nightly and the test passed:
> 
>   Passed: compiler/6823354/Test6823354.java
> 
> But they running on Niagara 1 machines which does not have popc
> so this code is not exercised.

Ahh, that explains it :-/

-- Christian


[prev in list] [next in list] [prev in thread] [next in thread]