[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-graal-dev
Subject:    Re: RFR: 8315637: JDK-8314249 broke libgraal
From:       Ioi Lam <iklam () openjdk ! org>
Date:       2023-09-07 18:29:40
Message-ID: L76bkVJyaBiYOR-blhWkFihmXg6pXmHNEWz8Sahf03w=.9ae6c932-10b0-40a2-85cb-9326de8ef132 () github ! com
[Download RAW message or body]

On Wed, 6 Sep 2023 07:01:16 GMT, Doug Simon <dnsimon@openjdk.org> wrote:

> > Please review this change in JVMCI. The actual functional change is essentially \
> > the same as the patch provided by @dougxc in \
> > [JDK-8315637](https://bugs.openjdk.org/browse/JDK-8315637) -- convert the \
> > `rawIndex` to `cpci` only if the bytecode is \
> > INVOKE{VIRTUAL,SPECIAL,STATIC,INTERFACE}. 
> > The rest of the changes is to rename the parameters from `rawIndex` to `which`, \
> > so we know the correct type of index is passed. I also added a test case. 
> > (This code should be much simpler after \
> > [JDK-8301993](https://bugs.openjdk.org/browse/JDK-8301993) is complete: we won't \
> > have `cpci` anymore and all `which` can be replaced with `rawInex`).
> 
> Thanks for the extra cleanup and tests.

Thanks @dougxc and @matias9927 for the review. The new code passed tiers 1 and 2. I \
also successfully built libgraal with this patch.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15575#issuecomment-1710598327


[prev in list] [next in list] [prev in thread] [next in thread]