[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-graal-dev
Subject: Re: RFR: 8313302: Fix formatting errors on Windows [v3]
From: Julian Waters <jwaters () openjdk ! org>
Date: 2023-07-29 4:59:58
Message-ID: qv0EebVJ8jwyNiUjEoTE3gN5FFuy9n_d9NetaTj9FNA=.a241f611-295e-42cd-a490-a6a0f97417dc () github ! com
[Download RAW message or body]
On Sat, 29 Jul 2023 00:38:18 GMT, Kim Barrett <kbarrett@openjdk.org> wrote:
> > long is 32-bit on Linux x86 and arm32 too.
>
> [not a review, just a drive-by comment]
> The type `long` really shouldn't be used in shared code. There have been \
> discussions and maybe some efforts to nuke uses, but having just done the grep, \
> there are still quite a few. The one in question might actually be an appropriate \
> place to use `uintx`.
Hi Kim, mind if you share the grep command for that?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15063#discussion_r1278246025
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic