[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-graal-dev
Subject:    Integrated: 8308396: Fix offset_of conversion warnings in runtime code
From:       Coleen Phillimore <coleenp () openjdk ! org>
Date:       2023-05-19 17:20:03
Message-ID: D0mW8s8sAvNJ8GcJVJMSbPPFIGnE3gN3y5uhZAFClPk=.389ab91f-6b18-4229-90c3-38fd9d069b4a () github ! com
[Download RAW message or body]

On Thu, 18 May 2023 22:37:57 GMT, Coleen Phillimore <coleenp@openjdk.org> wrote:

> Please review this change to use ByteSize and byte_offset_of() to refer to offsets \
> to metadata and other types that are used in generated code.  This avoids the int \
> narrowing conversion warning for -Wconversion.  There were a couple that I just \
> added an (int) cast instead because these offsets are either being used in other \
> code currently being changed (in oopDesc) or there are too many (like \
> displaced_header_offset_in_bytes) and should be their own change. 
> This change takes a  chunk out of the -Wconversion warnings - see CR for more info.
> 
> It might be easier and less tedious to review the commits separately.  One commit \
> renames blah_offset_in_bytes to blah_offset, since in_bytes(blah_offset()) is \
> typically used (except in Address constructor which has an overload for ByteSize). 
> Tested with tier1-4, x86 and aarch64, and built linux-x64-zero linux-x64-zero-debug \
> linux-aarch64-debug linux-s390x-open linux-arm32-debug linux-ppc64le-debug \
> linux-riscv64-debug locally.

This pull request has now been integrated.

Changeset: 265f40b4
Author:    Coleen Phillimore <coleenp@openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/265f40b4f70102c37bf28b2bf9dda16b92d1d975
                
Stats:     447 lines in 85 files changed: 11 ins; 9 del; 427 mod

8308396: Fix offset_of conversion warnings in runtime code

Reviewed-by: amitkumar, jsjolen, fparain

-------------

PR: https://git.openjdk.org/jdk/pull/14053


[prev in list] [next in list] [prev in thread] [next in thread]