[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-distro-pkg-dev
Subject:    [icedtea-web] PluginAppletViewer.java:1625 - Can "cl" be null?
From:       Thomas Meyer <thomas () m3y3r ! de>
Date:       2013-05-31 12:32:22
Message-ID: 1370003542.17521.6.camel () localhost ! localdomain
[Download RAW message or body]

Hi,

two questions/remarks:

1.) while debugging bug 1465 I hit a constellation where "cl" was null?
Is this something that could happen in reality or did I fumble to much
with the debugger?

--- a/plugin/icedteanp/java/sun/applet/PluginAppletViewer.java	Mon Jul 09 16:22:05 2012 -0400
+++ b/plugin/icedteanp/java/sun/applet/PluginAppletViewer.java	Fri May 31 12:49:17 2013 +0200
@@ -1625,9 +1625,10 @@
 
                 appletShutdown(p);
                 appletPanels.removeElement(p);
-                
+
                 // Mark classloader unusable
-                ((JNLPClassLoader) cl).decrementLoaderUseCount();
+                if(cl != null)
+                    ((JNLPClassLoader) cl).decrementLoaderUseCount();
 
                 try {
                     SwingUtilities.invokeAndWait(new Runnable() {

2.) While debugging bug 1465 I hit a funny constellation where the
underlying "juniper SSL connection" timed out and so in
net.sourceforge.jnlp.cache.ResourceTracker.downloadResource(Resource) I
did just receive an HTML file with the message, that my current session
timed out.
This HTML file was written to the cache directory, as "JICA-foo.jar". Is
the missing check for "Content-Type" in this method intentional?



[prev in list] [next in list] [prev in thread] [next in thread]