[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-distro-pkg-dev
Subject:    [icedtea-web] Proposed formatting for C++ side of plugin
From:       omajid () redhat ! com (Omair Majid)
Date:       2012-12-31 15:08:57
Message-ID: 50E1AA89.4080502 () redhat ! com
[Download RAW message or body]

On 12/28/2012 06:07 PM, Omair Majid wrote:
> On a quick look, one thing jumps out at me:
> 
> -bool
> -JavaRequestProcessor::newMessageOnBus(const char* message)
> -{
> +bool JavaRequestProcessor::newMessageOnBus(const char* message) {
> 
> The K&R indentation style places the opening brace in the line below the
> function prototype:
> 
> +bool JavaRequestProcessor::newMessageOnBus(const char* message)
> +{

I didn't mean to imply that this should be changed to conform to K&R
style, just that we should note that this is not exactly the same as K&R.

I like how this is similar enough to our Java style that you don't have
to think about formatting when switching from one language to the other.

Cheers,
Omair

-- 
PGP Key: 66484681 (http://pgp.mit.edu/)
Fingerprint = F072 555B 0A17 3957 4E95  0056 F286 F14F 6648 4681

[prev in list] [next in list] [prev in thread] [next in thread]