[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-distro-pkg-dev
Subject:    Revert wars, make dist, etc.
From:       ahughes () redhat ! com (Dr Andrew John Hughes)
Date:       2011-12-23 15:01:57
Message-ID: 20111223150157.GI22074 () rivendell ! middle-earth ! co ! uk
[Download RAW message or body]

On 14:05 Fri 23 Dec     , Pavel Tisnovsky wrote:
> Dr Andrew John Hughes wrote:
> > On 15:17 Wed 21 Dec     , Dr Andrew John Hughes wrote:
> >> On 10:27 Wed 21 Dec     , Andrew Haley wrote:
> >>> There's a continuing problem with the way that jtreg is handled in
> >>> IcedTea.
> >>>
> >>> The core problem seems to be that some parts of IcedTea need absolute
> >>> paths, and some need relative paths.  "make dist", in particular,
> >>> needs a relative path.  However, jtreg -othervm needs an *absolute*
> >>> path to the -exclude file.  So, it is clear that some uses need
> >>> JTREG_SRCS to be absolute, some need it to be relative.  We need
> >>> both, in other words.  It can't be one or the other.
> >>>
> >>> doko made a change in
> >>>
> >>> 	Fix running jamvm jdk tests when configured with a separate relative
> >>> 	build dir
> >>>
> >>> 	2011-12-08 Matthias Klose <doko at ubuntu.com>
> >>>
> >>> 	 * Makefile.am (JTREG_SRCS): Use abs_top_srcdir.
> >>>
> >>> which made JTREG_SRCS absolute.  This patch was not discussed.  I
> >>> complained that it broke "make dist", so doko pushed another patch
> >>>
> >>> 	Fix make dist, not using any prefixes in EXTRA_DIST
> >>>
> >>> 	2011-12-16 Matthias Klose <doko at ubuntu.com>
> >>>
> >>> 	 * Makefile.am (JTREG_SRCS, REWRITER_SRCS, EXTRA_DIST): Don't
> >>> 	use any prefixes. (stamps/jtreg.stamp, check-jdk):
> >>> 	Use JTREG_SRCS with srcdir prefix. (stamps/rewriter.stamp):
> >>> 	Use REWRITER_SRCS with srcdir prefix.
> >>>
> >>> which fixed that.  However, this patch was not discussed.
> >>>
> >>> Andrew Hughes backed this patch out, pointing out that it reverts a
> >>> number of earlier changes.  So, jtreg --othervm is broken, again.
> >>>
> >>> jtreg needs an absolute path.  Lets try and have a proper discussion
> >>> about how to do it, with no more commits or reversions until we've
> >>> decided together what to do.
> >>>
> >>> Andrew.
> >> I'm currently testing what I think may be the solution, which is to move
> >> the jtreg sources to src/jtreg removing the conflict between ./jtreg (the
> >> directory) and 'jtreg' (the rule alias).  With that change, the first of
> >> these patches can be reverted and JTREG_SRCS can use $(top_srcdir)/src/jtreg.
> >>
> >> I'll post the patch once I've done a few more tests and we can discuss it further.
> > 
> > In retrospect, I've pushed the patch after testing the change with two builds and
> > runs of jtreg & make dist.  Nearly all of it is just moving the jtreg directory
> > to live under the src tree, and so it made more sense to put the change in Mercurial
> > rather than posting a huge patch.  The only other change is to fix JTREG_SRCS:
> > 
> > -JTREG_SRCS = $(abs_top_srcdir)/jtreg
> > +JTREG_SRCS = $(top_srcdir)/src/jtreg
> > 
> > which should solve the problem with make dist not working when the path to configure
> > is relative.
> 
> Hi Andrew,
> 
> the latest changes (JTreg source moved to another directory) in Makefile.am broke
> JDK JTreg because the file excludelist.jdk.jtx is not found using relative path.

Ok, so you're running jtreg with a relative path to configure.  That's not something
I can easily test as running jtreg requires an entire build.  I tested jtreg with my
usual setup (abs. path to configure) and it worked.  make dist with both relative
and abs. paths worked.

As doko suggested on IRC, you need to ensure the path to excludelist.jdk.jtx is always
absolute.  Please don't change JTREG_SRCS as this breaks other parts of the build.
Localise any changes to the rules that break.

> I usually run JTreg using following very simple script:
> 
> rm -rf icedtea6
> hg fclone http://icedtea.classpath.org/hg/icedtea6
> cd icedtea6
> ./autogen.sh
> ./configure --disable-bootstrap --with-parallel-jobs=4
> make
> make check -k
> 
> Pavel
> 
> > 
> > If problems still remain, please mention them on the list and file a bug with details
> > of the configure flags.  All the configurations I've tried work with the current setup.
> 

-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: 248BDC07 (https://keys.indymedia.org/)
Fingerprint = EC5A 1F5E C0AD 1D15 8F1F  8F91 3B96 A578 248B DC07
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20111223/cba44320/attachment.bin 

[prev in list] [next in list] [prev in thread] [next in thread]