[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-distro-pkg-dev
Subject:    Request to backport 6736649 and 6797139
From:       omajid () redhat ! com (Omair Majid)
Date:       2011-01-24 21:34:05
Message-ID: 4D3DF04D.5090405 () redhat ! com
[Download RAW message or body]

On 01/24/2011 03:09 PM, Dr Andrew John Hughes wrote:
> On 14:49 Mon 24 Jan     , Omair Majid wrote:
>> On 01/18/2011 06:56 PM, Dr Andrew John Hughes wrote:
>>> On 16:26 Tue 18 Jan     , Omair Majid wrote:
>>>>>>>>>>> On 17:35 Fri 14 Jan     , Omair Majid wrote:
>>>>>>>>>>>> I would like to backport the following two changesets to openjdk6:
>>>>>>>>>>>>
>>>>>>>>>>>> changeset:   624:e78c2f17a606
>>>>>>>>>>>> user:        mlapshin
>>>>>>>>>>>> date:        Tue Aug 26 12:16:23 2008 +0400
>>>>>>>>>>>> summary:     6736649:
>>>>>>>>>>>> test/closed/javax/swing/JMenuItem/6458123/ManualBug6458123.java fails on
>>>>>>>>>>>> Linux
>>>>>>>>>>>>
>>>>>>>>>>>> changeset:   1637:281fbd82a971
>>>>>>>>>>>> user:        alexp
>>>>>>>>>>>> date:        Wed Sep 02 17:47:19 2009 +0400
>>>>>>>>>>>> summary:     6797139: JButton title is truncating for some strings
>>>>>>>>>>>> irrespective of preferred size.
>>>>>>>>>>>>
>>>>
>>>> changeset:   1738:9d78c3d9def2
>>>> user:        alexp
>>>> date:        Mon Sep 21 17:58:09 2009 +0400
>>>> summary:     6883341: SWAT: jdk7-b72 swat build(2009-09-17) threw
>>>> exceptions when running Java2D demo by clicking Paint ta
>>>>
>>>> This changeset gets rid of the StringIndexOutOfBoundsException (by
>>>> effectively reverting the exception changes).
>>>>
>>>
>>> Ok, so I guess I spotted it quicker than them ;-)
>>>
>>> Please backport this one as well.
>>>
>>
>> Done. Please see the attached patch.
>>
>>>>>>> Do the new tests pass?  They should be fixed to use the newer Oracle copyright notices.
>>>>>>>
>>
>> Updated the copyright headers.
>>
>
> Thanks.  Sorry for insisting on this, but they will to upstream them, so better
> to do it early.
>

That's true. It will make the backport to openjdk6 a little easier.

>>>>>>
>>>>>> Sorry, but I forgot to run the tests. I will fix the copyrights, run the
>>>>>> tests and post the results. I can confirm that the patch does fix the
>>>>>> issue pointed out in the bug report at
>>>>>> https://bugzilla.redhat.com/show_bug.cgi?id=661610
>>>>>>
>>>>>
>>>>> This sounds a good reason to backport.
>>>>>
>>>>> I'll await the results.
>>>>
>>>> I can confirm that the new tests pass. However, I also discovered that
>>>> swing programs using JMenus crash, so I didnt attempt to run all the tests.
>>>>
>>>> I will post an updated patch soon.
>>>>
>>
>> And here is the updated patch. I ran the jtreg tests and found no
>> related failures. I also ran netbeans using this build and nothing
>> seemed broken.
>>
>
> Great.  The question about tests was more for interest than a case of "we'll only
> allow this in if they pass", as the best place to fix such failures is with the changes
> committed and easily accessible for all.
>
>> Ok to commit?
>>
>
> Sure.
>

Thanks again for the extensive review! I have pushed this as changeset 
c78edcdba40f to icedtea6.

Cheers,
Omair


[prev in list] [next in list] [prev in thread] [next in thread]