[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-distro-pkg-dev
Subject:    Reviewer needed - two corrections in JTreg test harness
From:       mark () klomp ! org (Mark Wielaard)
Date:       2010-11-30 20:14:20
Message-ID: 1291148061.28640.6.camel () hermans ! wildebeest ! org
[Download RAW message or body]

Hi Pavel,

On Mon, 2010-11-22 at 17:42 +0100, Pavel Tisnovsky wrote:
> diff -r 789ec2d452bd -r eb0682d1be0d test/jtreg/com/sun/javatest/regtest/CompileAction.java
> --- a/test/jtreg/com/sun/javatest/regtest/CompileAction.java    Mon Nov 22 04:51:01 2010 +0100
> +++ b/test/jtreg/com/sun/javatest/regtest/CompileAction.java    Mon Nov 22 17:42:59 2010 +0100
> [...]
> +            Properties p = System.getProperties();
> +            for (Map.Entry<String,String> e: props.entrySet()) {
> +                String name = e.getKey();
> +                String value = e.getValue();
> +                if (name.equals("test.class.path.prefix")) {
> +                    System.err.println("*** java.class.path" + System.getProperty("java.class.path"));
> +                    Path cp = new Path(value, System.getProperty("java.class.path"));
> +                    p.put("java.class.path", cp.toString());
> +                } else {
> +                    System.err.println("prop: " + e.getKey() + "\t" + e.getValue());
> +                    p.put(e.getKey(), e.getValue());
> +                }
> +            }
> +            System.setProperties(p);
> +        }
> [... and a bit later in javatest/regtest/Action.java ...]
> +            // we just reset important props that were written in the test setup
> +            boolean resetAllSysProps;
> +            SecurityManager sm = System.getSecurityManager();
> +            if (sm instanceof RegressionSecurityManager) {
> +                resetAllSysProps = ((RegressionSecurityManager) sm).isPropertiesAccessed();
> +            } else {
> +                resetAllSysProps = true;
> +            }
> +            System.err.println("resetAllSysProps: " + resetAllSysProps);

These System.err.println are a little noisy. Do we really need them?

Thanks,

Mark


[prev in list] [next in list] [prev in thread] [next in thread]