[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-core-libs-dev
Subject:    Re: RFR: 8330467: NoClassDefFoundError when lambda is in a hidden class [v4]
From:       Mandy Chung <mchung () openjdk ! org>
Date:       2024-04-29 18:12:10
Message-ID: BDGL94e_BbPQm7zvXHRaVW2To_2UaCjwUFBW6Vop6LA=.0dc4ce76-ce07-44a8-a7f7-70a53715a005 () github ! com
[Download RAW message or body]

On Thu, 18 Apr 2024 05:54:17 GMT, Adam Sotona <asotona@openjdk.org> wrote:

> > Current implementation of `LambdaMetafactory` does not allow to use lambdas in \
> > hidden classes. Invocation throws `NoClassDefFoundError` instead. 
> > This patch includes lambda implementation in a hidden class under the special \
> > handling of `useImplMethodHandle`. The patch also fixes \
> > `j/l/i/defineHiddenClass/BasicTest::testLambda` to correctly cover this test \
> > case. 
> > Please review.
> > 
> > Thanks,
> > Adam
> 
> Adam Sotona has updated the pull request incrementally with one additional commit \
> since the last revision: 
> Update src/java.base/share/classes/java/lang/invoke/InnerClassLambdaMetafactory.java
>  
> Co-authored-by: Mandy Chung <mandy.chung@oracle.com>

HiddenTest is not a hidden class in this test.  So it should be fine.   The bottom \
line is to ensure that the type reference is not a hidden class.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18810#issuecomment-2083352956


[prev in list] [next in list] [prev in thread] [next in thread]