[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-core-libs-dev
Subject:    Re: RFR: JDK-8301392: Port fdlibm log1p to Java [v2]
From:       Joe Darcy <darcy () openjdk ! org>
Date:       2023-01-31 19:15:16
Message-ID: 8EMw8wkXEtUyz8c_GejlsH1DprGfbMzOJlUldSo-oYI=.442b5ae7-e89c-4d31-bb76-fca55f10aedd () github ! com
[Download RAW message or body]

On Tue, 31 Jan 2023 06:49:28 GMT, Andrey Turbanov <aturbanov@openjdk.org> wrote:

> > Joe Darcy has updated the pull request incrementally with one additional commit \
> > since the last revision: 
> > Implement review feedback.
> 
> src/java.base/share/classes/java/lang/FdLibm.java line 911:
> 
> > 909:             k = 1;
> > 910:             if (hx < 0x3FDA827A) {                  /* x < 0.41422  */
> > 911:                 if(ax >= 0x3ff00000) {                /* x <= -1.0 */
> 
> Suggestion:
> 
> if (ax >= 0x3ff00000) {                /* x <= -1.0 */

Changed; thanks.

-------------

PR: https://git.openjdk.org/jdk/pull/12301


[prev in list] [next in list] [prev in thread] [next in thread]