[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-core-libs-dev
Subject:    Re: RFR: 8291651: CleanerTest.java fails with "Cleanable was cleaned" [v2]
From:       Daniel Fuchs <dfuchs () openjdk ! org>
Date:       2022-08-31 8:54:08
Message-ID: v5KkE-LLuJMjNA_1rpZ4x0eiualsbAasOcMOPGIVAYc=.4504dc8d-f574-4afc-b261-aba2f684dbd3 () github ! com
[Download RAW message or body]

On Tue, 30 Aug 2022 18:33:24 GMT, Roger Riggs <rriggs@openjdk.org> wrote:

> > CleanerTest is failing intermittently on Aarch64, with -Xcomp, and using a \
> > VirtualThread for the Cleaner in the test. The extensively relies on references \
> > processing and invokes GC on a very short cycle. The existing 10ms delay between \
> > GC requests is too short for the changes to reference states to be reliably \
> > visible. 
> > The delay between gc requests is extended to 200ms and the tests pass reliably.
> > There are small improvements in diagnostic messages and cleanup of unused \
> > imports.
> 
> Roger Riggs has updated the pull request incrementally with one additional commit \
> since the last revision: 
> Cleanup of messages that describe the cleaning function to be run or not.
> Switched to using jtreg @enablePreview.

Thaks @RogerRiggs - the new messages LGTM.

-------------

Marked as reviewed by dfuchs (Reviewer).

PR: https://git.openjdk.org/jdk/pull/10048


[prev in list] [next in list] [prev in thread] [next in thread]