[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-core-libs-dev
Subject:    Re: RFR: 8292983: ModuleReferenceImpl.computeHash should record algorithm for cache checks [v4]
From:       Aleksey Shipilev <shade () openjdk ! org>
Date:       2022-08-29 5:57:22
Message-ID: wj_By541fTBSd6nHv2zwRXuQZZv1Ryje2jAkXHsJwR8=.dbc4567b-49b5-4a27-8b87-3a072e5759bb () github ! com
[Download RAW message or body]

On Fri, 26 Aug 2022 15:06:16 GMT, Aleksey Shipilev <shade@openjdk.org> wrote:

> > Look at implementation and figure out what happens if you do:
> > 
> > 
> > computeHash("SHA-1") = someHash;
> > computeHash("SHA-256") = ...?
> > 
> > 
> > The caching method should actually check the algorithms match.
> > 
> > Not a bug at this point, since only use SHA-256 today, but this is a landmine \
> > ready to fire.  
> > Additional testing:
> > - [x] Linux x86_64 release, `java/lang/module` tests
> 
> Aleksey Shipilev has updated the pull request incrementally with one additional \
> commit since the last revision: 
> Comments

Thank you all.

-------------

PR: https://git.openjdk.org/jdk/pull/10044


[prev in list] [next in list] [prev in thread] [next in thread]