[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-core-libs-dev
Subject:    Re: RFR: 8269373: some tests in jdk/tools/launcher/ fails on localized Windows platform
From:       Naoto Sato <naoto () openjdk ! java ! net>
Date:       2021-06-29 19:29:04
Message-ID: pw_h06tc543T0y4KWDzX6w9hikvWAPEoNYrVaFVgbNU=.c6f6338a-637e-4cbf-a88a-7f5c9fa967b1 () github ! com
[Download RAW message or body]

On Fri, 25 Jun 2021 12:10:18 GMT, Masanori Yano <myano@openjdk.org> wrote:

> Hi all,
> 
> Could you please review the 8269373 bug fixes?
> 
> These tests call java.lang.ProcessBuilder in direct, so not used jtreg command \
> option. To run non-localized tests, -Duser.language=en and -Duser.country=US \
> options should be added in ProcessBuilder.

From a peek at the bug report, I could not find out the exact cause why they are \
failing. Have you figured it out?

As to the fix itself, I would rather avoid hardcoding `en-US` in the argument. Would \
that be replaced with the launching process' locale?

-------------

PR: https://git.openjdk.java.net/jdk/pull/4594


[prev in list] [next in list] [prev in thread] [next in thread]