[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-core-libs-dev
Subject:    Re: RFR: 8248862: Implement Enhanced Pseudo-Random Number Generators [v3]
From:       Roger Riggs <rriggs () openjdk ! java ! net>
Date:       2021-02-26 21:53:47
Message-ID: 0VaZHVlAPVPZOyMk1UK1j3ujLDQEwYeYx3dG_cwBHfA=.9d457d8b-4625-4943-ae0f-935d2462f31d () github ! com
[Download RAW message or body]

On Wed, 25 Nov 2020 16:22:32 GMT, Jim Laskey <jlaskey@openjdk.org> wrote:

>> src/java.base/share/classes/java/util/random/RandomGeneratorFactory.java line 106:
>> 
>>> 104:      * Map of provider classes.
>>> 105:      */
>>> 106:     private static volatile Map<String, Provider<? extends RandomGenerator>> factoryMap;
>> 
>> should be FACTORY_MAP given that it's a static field
>
> will fall out of using  class holder idiom

IntelliJ warns that this volatile field is unused. It has been replaced by the method getFactoryMap().

-------------

PR: https://git.openjdk.java.net/jdk/pull/1292
[prev in list] [next in list] [prev in thread] [next in thread]