[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-core-libs-dev
Subject:    Re: RFR: 8260869: Test java/foreign/TestHandshake.java fails intermittently
From:       Paul Sandoz <psandoz () openjdk ! java ! net>
Date:       2021-02-26 17:58:41
Message-ID: Abs3A1X9HZu1aaJRGNhEu6Eeq7BO8Xmrbxh6ftXia_s=.5750fa1b-043b-4590-baf5-4c400f1c296c () github ! com
[Download RAW message or body]

On Fri, 26 Feb 2021 14:25:09 GMT, Maurizio Cimadamore <mcimadamore@openjdk.org> \
wrote:

> This simple fix reduces the amount of concurrency on the foreign memory \
> TestHandshake test. As this test spins a new accessor thread for each available \
> processors, on machines which feature an high number of available processors \
> (because of multi-threading), and which are slower in forking new threads (e.g. \
> Windows), the test can sometimes timeout. 
> The sensible step, for now, is to introduce an hard limit on the number of \
> concurrent accessor threads being created. I've looked at the test logs quite in \
> depth, and there's nothing suggesting that something else is amiss - the number of \
> concurrent threads just seem to be too high in some instances.

test/jdk/java/foreign/TestHandshake.java line 60:

> 58: 
> 59:     static final int NUM_ACCESSORS = Math.max(10, \
>                 Runtime.getRuntime().availableProcessors());
> 60: 

`min` rather than `max` so as to clamp at a maximum of 10 accessors?

-------------

PR: https://git.openjdk.java.net/jdk/pull/2748


[prev in list] [next in list] [prev in thread] [next in thread]