[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-core-libs-dev
Subject:    Re: RFR: JDK-8262199: issue in jli args.c [v5]
From:       Alan Bateman <alanb () openjdk ! java ! net>
Date:       2021-02-26 8:41:43
Message-ID: c_kez-HBGfNTaz33IykyhGZCrHCUXJdzXs8PI6QIbCk=.ca4a3e1f-147a-41e1-952e-4a14ea0e926a () github ! com
[Download RAW message or body]

On Fri, 26 Feb 2021 08:31:00 GMT, Matthias Baesken <mbaesken@openjdk.org> wrote:

> > Sonar reports a finding in args.c, where a file check is done .
> > Stat performs a check on file, and later fopen is called on the file .
> > 
> > The coding could be slightly rewritten so that the potential issue is removed \
> > (however I do not think that it is such a big issue).
> 
> Matthias Baesken has updated the pull request incrementally with one additional \
> commit since the last revision: 
> Replace reportAndExit

This version looks good too.

-------------

Marked as reviewed by alanb (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/2692


[prev in list] [next in list] [prev in thread] [next in thread]