[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-core-libs-dev
Subject:    Re: 8260403: javap should be more robust in the face of invalid class files
From:       Adam Sotona <adam.sotona () oracle ! com>
Date:       2021-02-25 15:58:47
Message-ID: 537EE7B0-8993-4F51-B595-2D533D6B2261 () oracle ! com
[Download RAW message or body]

Hi Vicente,
thanks for the review.

May I ask you also to /sponsor this PR?

Thanks again,
Adam


On 25/02/2021, 16:39, "core-libs-dev on behalf of Vicente Romero" \
<core-libs-dev-retn@openjdk.java.net on behalf of vromero@openjdk.java.net> wrote:

    On Thu, 25 Feb 2021 13:01:30 GMT, Adam Sotona <asotona@openjdk.org> wrote:

    > Please review javap fix to handle java.lang.IllegalStateException for classes \
with invalid Signature attribute.  > New test (T8260403) parsing class with invalid \
Signature attribute (as described in the bug) is included.  > Fix wraps \
java.lang.IllegalStateException, reports "Error: Invalid value for Signature \
attribute: <signature debug info>" and continues.  > 
    > Thanks,
    > Adam

    lgtm!

    -------------

    Marked as reviewed by vromero (Reviewer).

    PR: https://git.openjdk.java.net/jdk/pull/2724


[prev in list] [next in list] [prev in thread] [next in thread]