[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-core-libs-dev
Subject:    Re: RFR: 8259074: regex benchmarks and tests [v2]
From:       Aleksey Shipilev <shade () openjdk ! java ! net>
Date:       2021-01-31 8:21:43
Message-ID: IIoQfO6LUBHTkmBhyCG7MD2MZGYDB6ZZWOp63OWZHRA=.990000c9-719a-4d55-b509-67dfafd39908 () github ! com
[Download RAW message or body]

On Sat, 30 Jan 2021 22:43:10 GMT, Martin Buchholz <martin@openjdk.org> wrote:

> > 8259074: regex benchmarks and tests
> 
> Martin Buchholz has updated the pull request incrementally with one additional \
> commit since the last revision: 
> address comments from @amalloy; introduce technically correct use of "numeral"

test/micro/org/openjdk/bench/java/util/regex/Trim.java line 119:

> 117:         assert ! lookBehind_find();
> 118:         assert ! find_loop_two_matchers();
> 119:         assert ! find_loop_usePattern();

At a risk of muddling the profiles a bit, this can be rewritten as:

 if (!simple_find()) throw new IllegalStateException("simple_find is incorrect");
 ...

-------------

PR: https://git.openjdk.java.net/jdk/pull/1940


[prev in list] [next in list] [prev in thread] [next in thread]