[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-core-libs-dev
Subject:    Re: RFR: 8249867: xml declaration is not followed by a newline [v3]
From:       Joe Wang <joehw () openjdk ! java ! net>
Date:       2021-01-29 19:33:48
Message-ID: oddRAeHrzln20JcSFi7D7ZSXDw2tfZYrAUyw-uyVt38=.1bbc7f6c-7086-4af9-8457-61e5650234f4 () github ! com
[Download RAW message or body]

On Fri, 29 Jan 2021 17:57:14 GMT, Daniel Fuchs <dfuchs@openjdk.org> wrote:

> > Joe Wang has updated the pull request incrementally with one additional commit \
> > since the last revision: 
> > Updated the patch based on review comments. Refer to the previous reviews.
> 
> src/java.xml/share/classes/module-info.java line 188:
> 
> > 186:  * </tbody>
> > 187:  * </table>
> > 188:  *
> 
> One question is whether the code samples in the table above should be escaped with \
> {@code }. e.g.: 
> <td>
> {@code first line of code;}<br>
> {@code second line of code;}<br>
> </td>

Looks better.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2041


[prev in list] [next in list] [prev in thread] [next in thread]