[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-core-libs-dev
Subject:    RE: RFR:  8234821: remove unused functions from libjli
From:       "Baesken, Matthias" <matthias.baesken () sap ! com>
Date:       2019-11-28 12:02:17
Message-ID: AM6PR02MB5078BBE4F72887377B96666193470 () AM6PR02MB5078 ! eurprd02 ! prod ! outlook ! com
[Download RAW message or body]

Thanks for the review . I'll adjust the COPYRIGHT .

Will push this as XS in case of no objections.

Best regards, Matthias


> -----Original Message-----
> From: Langer, Christoph <christoph.langer@sap.com>
> Sent: Donnerstag, 28. November 2019 11:35
> To: Baesken, Matthias <matthias.baesken@sap.com>; core-libs-
> dev@openjdk.java.net
> Subject: RE: RFR: 8234821: remove unused functions from libjli
> 
> Hi Matthias,
> 
> overall this looks good to me.
> 
> The only change to src/java.base/share/native/libjli/jli_util.c is the
> copyrights, so I guess this should be omitted...
> 
> Cheers
> Christoph
> 
> > -----Original Message-----
> > From: core-libs-dev <core-libs-dev-bounces@openjdk.java.net> On Behalf
> > Of Baesken, Matthias
> > Sent: Mittwoch, 27. November 2019 09:56
> > To: core-libs-dev@openjdk.java.net
> > Subject: [CAUTION] RE: RFR: 8234821: remove unused functions from libjli
> >
> > Hello,  I missed the  reference from windows only code to JLI_MemRealloc
> ,
> > new webrev :
> >
> > http://cr.openjdk.java.net/~mbaesken/webrevs/8234821.1/
> >
> > Best regards, Matthias
> >
> >
> >
> > Hello, please review  this small change .
> > It removed  unneeded functions from libjli (shown  by  link-time-gc) .
> >
> > libjli contains a few functions that are shown as unused when applying link-
> > time-gc .
> > Those functions fall into 2 categories :
> > - totally unused/uncalled functions   (can be deleted )
> > - functions that are always inlined, but still kept separate when linking
> > (making them static often helps to remove the unneeded duplicate )
> >
> >
> >  ( Similar approach has been done to libnet , see : 8234629: remove unused
> > functions from libnet )
> >
> >
> >
> > Thanks, Matthias
> >
> >
> > Bug/webrev :
> >
> > https://bugs.openjdk.java.net/browse/JDK-8234821
> >
> > http://cr.openjdk.java.net/~mbaesken/webrevs/8234821.0/
> >

[prev in list] [next in list] [prev in thread] [next in thread]