[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-core-libs-dev
Subject:    RE: <i18n dev> [13] RFR: 8226876: Assertion in sun/util/locale/provider/CalendarDataUtility on Windo
From:       "Langer, Christoph" <christoph.langer () sap ! com>
Date:       2019-06-27 21:18:01
Message-ID: AM6PR02MB519220B8BB24290A35DF23D68AFD0 () AM6PR02MB5192 ! eurprd02 ! prod ! outlook ! com
[Download RAW message or body]

Sounds great. Thank you.

> -----Original Message-----
> From: naoto.sato@oracle.com <naoto.sato@oracle.com>
> Sent: Donnerstag, 27. Juni 2019 23:16
> To: Langer, Christoph <christoph.langer@sap.com>; i18n-
> dev@openjdk.java.net; core-libs-dev <core-libs-dev@openjdk.java.net>
> Subject: Re: <i18n dev> [13] RFR: 8226876: Assertion in
> sun/util/locale/provider/CalendarDataUtility on Windows after JDK-8218960
> 
> Thanks for the review, Christoph.
> 
> I'll wait for a whole day so that everyone sees the fix. Planning to
> push it tomorrow.
> 
> Naoto
> 
> On 6/27/19 2:05 PM, Langer, Christoph wrote:
> >>> The change looks good to me. But I would say the assertion in
> >> CalendarDataUtility in line 266 is pointless now, isn't it?
> >>
> >> Yes, but would not hurt leaving it. It would catch error if yet another
> >> case is installed (and it forgot to provide a default value) in the
> >> switch statement. So I just left it.
> >
> > Ok, sounds reasonable.
> >
> > What's your target for pushing this? I'd like to backport it to OpenJDK 11.0.4
> to fix the regression there...
> >
> > /Christoph
> >

[prev in list] [next in list] [prev in thread] [next in thread]