[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-core-libs-dev
Subject:    Re: RFR: JDK-8218055: Use ToolProvider instead of AppRuntimeImageBuilder.
From:       Alexander Matveev <alexander.matveev () oracle ! com>
Date:       2019-02-25 22:55:50
Message-ID: 7e54ad71-2bfc-1b44-2781-8ce6305eac58 () oracle ! com
[Download RAW message or body]

Hi Andy,

Updated version looks fine as well.

Thank,
Alexander

On 2/25/2019 5:19 AM, Andy Herrick wrote:
> I uploaded webrev version 04 
> (http://cr.openjdk.java.net/~herrick/8218055/webrev.04) which is same 
> as version 03 except "JLink" is changed to "jlink" in several messages.
>
> /ANdy
>
>
> On 2/22/2019 2:37 PM, Mandy Chung wrote:
>>
>>
>> On 2/22/19 9:50 AM, Andy Herrick wrote:
>>> revised webrev t address issues brought up by Mandy:
>>>
>>> [2] http://cr.openjdk.java.net/~herrick/8218055/webrev.03
>>
>> I only looked at JLinkBundlerHelper.java and the removed
>> files that look okay.   Nit: can you use "jlink" lower case
>> in the log/exception message (that's the tool's name).
>>
>> Someone else who knows this area should review.
>>
>> Mandy
>

[prev in list] [next in list] [prev in thread] [next in thread]